Bug: 4 emails sent when submitted once!

[Anon]

PHP 3.0.16

I have a form than takes a users email and submits it to my sub.php. Sub.php checks the email for proper format, and then if correct, sends a "[e-mail] has Subscribed" email back to my mail processor. However, if the user incorrectly inputs email, he must try again. Once inputed correctly, the email is sent back home, but is sent once for the correct version, and then is sent again (with the correct address) the same amount of times that a mistake was made (4 input errors + 1 correct input = 5 correct subscription emails).

The code is fine. I think it has something to do with IE6 caching either the php file or the actual email form. However, I'm already including these in my script:

---

header( "Expires: Mon, 20 Dec 1998 01:00:00 GMT" );

header( "Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT" );

header( "Cache-Control: no-cache, must-revalidate" );

header( "Pragma: no-cache" );

---

I'm lost... please help.
~Chris

[[deleted]]

"The code is fine."

Somehow I doubt that.

<brainstorm mode>
I think there may be some variable that grows everytime the user makes a mistake, and when the user fixes the mistake, that var is read and it somehow sends mail based on the content of that var.

For example, you could have a form variable that contains the 'TO:' address, and everytime the user makes a mistake, somehow your address get's appended to that var.
After four tries, your address is in there 4 times and the email get's sent 4 times.

</brainstorm mode>

[Anon]

brainstorm (mode) {

ummm.. can a variable based on a form text field be automatically converted into an array? You said that my code probably wasn't fine... if so, then suggest something, please. How would I reset the variables? And when do I do reset; before the 'header' for the error msg.html is sent?

}

[Anon]

HERE'S MY CODE:

<?
header( "Expires: Mon, 20 Dec 1998 01:00:00 GMT" );
header( "Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT" );
header( "Cache-Control: no-cache, must-revalidate" );
header( "Pragma: no-cache" );

if (!isset($email)) {
header( "Location: http://www.sample.com/sub_err.htm#1" );
}
elseif (empty($email)) {
header( "Location: http://www.sample.com/sub_err.htm#2" );
}
elseif (strlen($email) < 6) {
header( "Location: http://www.sample.com/sub_err.htm#3" );
}
else {
$flag = "0";
$top = strlen($email);
for ($i = 0; $i < $top; $i++) {
if (substr($email, $i, 1) == "@") $flag = "1";
}
for ($i = 0; $i < $top; $i++) {
if (substr($email, $i, 1) == " ") $flag = "0";
}
if ($flag == "1") {
mail(
"[e-mail]",
"_SUBSCRIBE",
"SAMPLE NEWSLETTER SUBSCRIPTION",
"From: $email" );
header( "Location: http://www.sample.com/thankyou.htm" );
}
else {
header( "Location: http://www.sample.com/sub_err.htm#4" );
}
}
?>

WHAT'S WRONG WITH IT?
SHOULD I RESET THE FORM VARIABLE $email?

vincent wrote:

"The code is fine."

Somehow I doubt that.

<brainstorm mode>
I think there may be some variable that grows everytime the user makes a mistake, and when the user fixes the mistake, that var is read and it somehow sends mail based on the content of that var.

For example, you could have a form variable that contains the 'TO:' address, and everytime the user makes a mistake, somehow your address get's appended to that var.
After four tries, your address is in there 4 times and the email get's sent 4 times.

</brainstorm mode>

[kycan]

echo out $email and see what pops up.

[[deleted]]

Hmmm you code looks simple enough.
I'd make one change though: put an exit() after each header(), because your script should not continue after sending the "location" header.

What's the code for the suberr.htm page?

[Anon]

Thanks Vincent...

I didn't think exit() would be necessary since the there was no code outside the if statements. I figured it would exit naturally anyway. I guess not. It works now.

[[deleted]]

Scripts only exit when you tell them to :-)