Row Counting

[Anon]

I am trying to return a query of (3) columns and desire to add a row counter in front of these (3) columns of data. I am probably overlooking something simple and I can't quite get there. This query returns 25 rows of data and it outputs the number 25 in all the rows, not starting from 1 and going to 25. Any help would be appreciated.

Here is my query and code:

$GetData = mysql_query ("select
year,
record,
conferences.longname as name

      from cchamps, conferences

	  where cchamps.teamid = '$team'
	  and cchamps.confid = conferences.conid

	  group by year

	  order by year");

$rows = mysql_num_rows($GetData);

$no=0;

if ($GetDataArray = mysql_fetch_array($GetData))

{

do
{   
	for ($no=0; $no < $rows; $no++)

	$year = $GetDataArray["year"];
	$record = $GetDataArray["record"];
	$name = $GetDataArray["name"];

    $tpl->assign("NO", $no);
	$tpl->assign("YEAR", $year);
	$tpl->assign("RECORD", $record);
	$tpl->assign("CONFERENCE", $name);

	$tpl->parse (ROWS, ".rows");
}
while ($GetDataArray = mysql_fetch_array($GetData));

$tpl->parse(DATA, "table");
$tpl->parse(TEST, "toplevel");
$tpl->FastPrint();

}

David

[[deleted]]

for ($no=0; $no < $rows; $no++)

there's your problem, a FOR loop without {} backets.
That means it will execute the next statement only.

In your case, you use the do..while loop to fetch each record, and for every record, the FOR loop executes
$year = $GetDataArray["year"];
as many times are there are rows.

what PHP does looks like this:
do
{
&nbsp;for ($no=0; $no < $rows; $no++)
&nbsp;{
&nbsp;&nbsp;$year = $GetDataArray["year"];
&nbsp;};
&nbsp;$record = $GetDataArray["record"];
&nbsp;$name = $GetDataArray["name"];

A few sidenotes about your code in general:

DO...WHILE loops are evil because you always have to manually check wether the loop should be started at all.

mysql_num_rows() returns the number of records. If it is zero, you can stip printing the table. You don't need to use the 'expensive' mysql_fetch_array() to find out.

try this instead:

$rows&nbsp;=&nbsp;mysql_num_rows($GetData);&nbsp;

if&nbsp;($rows>0)
{
&nbsp;&nbsp;for&nbsp;($no&nbsp;=&nbsp;0;&nbsp;$no<$rows;&nbsp;$no++)
&nbsp;&nbsp;{
&nbsp;&nbsp;&nbsp;&nbsp;$GetDataArray&nbsp;=&nbsp;mysql_fetch_array($GetData))&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$year&nbsp;=&nbsp;$GetDataArray["year"];&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$record&nbsp;=&nbsp;$GetDataArray["record"];&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$name&nbsp;=&nbsp;$GetDataArray["name"];&nbsp;

&nbsp;&nbsp;&nbsp;&nbsp;$tpl->assign("NO",&nbsp;$no);&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$tpl->assign("YEAR",&nbsp;$year);&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$tpl->assign("RECORD",&nbsp;$record);&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$tpl->assign("CONFERENCE",&nbsp;$name);&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;$tpl->parse&nbsp;(ROWS,&nbsp;".rows");&nbsp;
&nbsp;&nbsp;};
&nbsp;&nbsp;$tpl->parse(DATA,&nbsp;"table");&nbsp;
&nbsp;&nbsp;$tpl->parse(TEST,&nbsp;"toplevel");&nbsp;
&nbsp;&nbsp;$tpl->FastPrint();&nbsp;
};

---

A forum, a FAQ, what else do you need?

Time to YAPF!: http://www.hvt-automation.nl/yapf/

[Anon]

That works fine. Thank you for the tip.

David