PLZ HELP

[Anon]

HI,
I have a problam with my script, it checks the user's details from a file, the bank script i have made is slightly not working,

When a user deposites 25 into the bank, and then withdraws 100, (this is starting with 0)
it puts the bank account to -75, how can i make it so it won't withdraw if there is not enough?

Here is the script i use:

<?php
} else {
$userlist = file("users.inc.php");
$done = false;
$auth = false;
$found = false;
$i = 0;
while ((!$found) && ($i<count($userlist))) {
$i++;
list($n,$p,$a,$e,$g,$s,$m,$a1) = explode(':',$userlist[$i]);
$found = ($n==$user);
echo "<br>Please Wait...";
} if ($com == 2 && $m <= $price) { die("<br>Error: You don't have enough money<br>"); }
elseif ($com == 1 && $a1 <= $price) { die("<br>Error: You don't have enough money in your account<br>"); }
elseif (!$com) { die("<br>Error: You must select either Deposit or withdraw<br>"); }
elseif ($com == 2 && $m >= $price) {
$m -= $price;
$a1 += $price;
$m = ($m < $price) ? $m : $m;
$a1 = ($m < $price) ? $a1 : $a1;
$userlist[$i] = implode(':',array($n,$p,$a,$e,$g,$s,$m,$a1));
$fd = fopen("users.inc.php","w");
fputs($fd,"<?php die(\"Access restricted\"); ?>\n");
for ($i=1; $i<count($userlist); $i++) {
fputs($fd,chop($userlist[$i])."\n");
}
fclose($fd);
echo "<script>window.opener.document.location.reload(); window.close();</script>";
}
elseif ($com == 1 && $a1 >= $price) {
$m += $price;
$a1 -= $price;
$m = ($m < $price) ? $m : $m;

$a1 = ($a1 < $price) ? $a1 : $a1;
$userlist[$i] = implode(':',array($n,$p,$a,$e,$g,$s,$m,$a1));
$fd = fopen("users.inc.php","w");
fputs($fd,"<?php die(\"Access restricted\"); ?>\n");
for ($i=1; $i<count($userlist); $i++) {
fputs($fd,chop($userlist[$i])."\n");
}
fclose($fd);
echo "<script>window.opener.document.location.reload(); window.close();</script>";
}
}
?>

The form has radio butons to choose $com, $com as 1 is withdraw and 2 is deposit, $m is the users money and $a1 is the bank account.

thanxs to all the help,

[tomhath]

You have run into a pretty subtle problem. Since php doesn't have typed variables, it tries to guess what you want (integer, string, float, etc). Sometimes it guesses wrong. It looks like it is doing a string comparison on $a1 and $price when you expected numeric. See what the manual says about Type Juggling and Type Casting. This illustrates the problem:

<?php

$a1 = "25";
$m = "100.00 ";
if ($a1 > $m) {
echo "$a1 is greater than $m";
}
else {
echo "$a1 is less than $m";
}
?>

Also you have these lines in your script in a couple of places, obviously they won't do anything.

$m = ($m < $price) ? $m : $m;
$a1 = ($m < $price) ? $a1 : $a1;

[Anon]

that would work but it has 2 functions, depositing money and withdrawing money :-\

I will fiddle with the script you have said, though

Thanxs for your help,

[Anon]

just thinking, no wat u put won't work, it needs to check that $a1 is over $price when $com = 1

[tomhath]

The logic in your script is okay. Reread what I posted the first time. You are not comparing an amount of money in the account ($a1) to the price ($price). You are comparing two character strings. Look at it this way:

"zz" > "aaa"

"25" > "100.00 "

Comparing strings of digits (in my example "25" and "100.00 ") is not the same as comparing the number 25 to the number 100.00

As I recommended before, read about Type Casting. Also learn what the term "collating sequence" means.

[Anon]

I still haven't a clue what u mean,