is_dir problem

[Anon]

Hi,

I'vge got piece of code that collects all the files in a certain directory ($path) en puts them in an array. Now I'd like to display only the directories in a selectbox. I've tried this, but something seems to go wrong: in $path there are 3 different directories, but only one (the first one) is being displayed in the selectbox. I've pasted the relevant code below, what am I doing wrong ... ??

Thanks in advance, Michiel

<?php
if (!$dir)
{
$i=0;
$dirs = array();
$handle=opendir("$path");
while ($dir = readdir($handle))
{
$dirs[$i] = $dir;
$i++;
}

        closedir($handle); 
        sort($dirs); 
        reset($dirs); 

        if (sizeof($dirs) == 0) 
           { 
           echo("Er zijn geen mappen gevonden"); 
           } 
        else 
           { 
           echo("<FORM name=\"setdir\" action=\"admin.php\">\n"); 
           echo("<INPUT type=\"hidden\" name=\"typedpassword\" value=\"$typedpassword\">\n"); 
           echo("<INPUT type=\"hidden\" name=\"typedusername\" value=\"$typedusername\">\n"); 
           echo("<SELECT name=\"dir\">\n"); 
           echo("<OPTION value=\"\">Kies een map</OPTION>\n"); 
           for ($j=0;$j<sizeof($dirs);$j++) 
               { 
               if (is_dir($dirs[$j])) 
                  { 
                  echo ("<OPTION value=\"/$dirs[$j]\">$dirs[$j]</OPTION>\n"); 
                  } 
               } 
           echo("</SELECT>\n"); 
           echo("<INPUT type=\"submit\" value=\"kies map\">\n"); 
           echo("</FORM>\n"); 
           } 
       } 

?>

[van__]

lose this...
<?
for ($j=0;$j<sizeof($dirs);$j++)
{
if (is_dir($dirs[$j]))
{
echo ("<OPTION value=\"/$dirs[$j]\">$dirs[$j]</OPTION>\n");
}
}
?>

the use of is_dir here is wrong, you are no longer reading from a file pointer.

this should work:
<?
for ($j=0;$j<sizeof($dirs);$j++)
{
echo ("<OPTION value=\"/$dirs[$j]\">$dirs[$j]</OPTION>\n");
}
?>

[Anon]

Hi,

this is what I had initially, but then the regular files (like .dat, .html, .php) in the directory $path are also displayed. I'm trying to achieve that the directories are seperated from the regular files in the directory $path. And <I>only</I> the directories should be displayed in the selectbox.

Michiel

[van__]

Michiel wrote:

Hi,

this is what I had initially, but then the regular files (like .dat, .html, .php) in the directory $path are also displayed. I'm trying to achieve that the directories are seperated from the regular files in the directory $path. And <I>only</I> the directories should be displayed in the selectbox.

Michiel

Well of course you go everything in your array. You didn't tell it to only put DIRS in there.

$handle=opendir("$path");
while ($dir = readdir($handle))
{
if (is_dir($dir)) { $dirs[$i] = $dir; $i++; }

}

[Anon]

I thought it would be easier to put everything in the array first, and then filter it. But this method indeed makes more sense: why put it in an array if you're not gonna use it, right 🙂

Thanx verry much, Michiel