newbie needs help!!! bad script?

fowlerlfc

Hello,

I know this will probably be a dumb mistake on my part, but I can't get the following script to run. Could someone please proofread it for me and help me out? Also, since I'm learning if you'd be so kind as to critique my work, that would also be helpful.

Here's the script:

<head>
<title>Workorder submission form</title>
</head>
<body>
<?
//haven't submitted form, so display it
if (!$submit)
{
?>
<table cellspacing="5" cellpadding="5">
<form action="<?echo $PHP_SELF; ?>" method="post">
<tr>
<td>Name:</td>
<td><input size="50" maxlength="250" type="text" name="name"></td>
</tr>
<tr>
<td>Extension:</td>
<td><input size="4" maxlength="4" type="text" name="ext"></td>
</tr>
<tr>
<td>Email:</td>
<td><input size="50" maxlength="250" type="text" name="email"></td>
</tr>
<tr>
<td>Issue/Error/Problem:</td>
</tr>
<tr>
<td><textarea name="issue" cols="40" rows="20"></textarea></td>
</tr>
<tr>
<td><input type="submit" name="submit" value="Add"></td>
</tr>
</form>
</table>
<?
}
else
{
//includes files
include("../conf.php");
include("../functions.php");

//setup up an error list array
$errorlist = array();
$count = 0;

//validate name field
if ($name) { $errorlist[$count] = "Invalid entry: Name"; count++; }

//validate ext field
if ($ext) { $errorlist[$count] = "Invalid entry: Extension"; count++; }

//validate email field
if ($email) { $errorlist[$count] = "Invalid entry: Email"; count++; }

//validate issue field
if ($issue) { $errorlist[$count] = "Invalid entry: Issue/Error/Problem"; count++; }

//check for errors in errorlist.
if (sizeof($errorlist)==0)
{
//if no errors found
//open db connection
$connection = mysql_connect($host, $user, $pass) or die("Unable to Connect!");
//select db
mysql_select_db($db) or die("Unable to select database!");
//generate and run query
$query = "INSERT INTO wo(name, ext, email, issue, timestamp) VALUES ('$name', '$ext', '$email', '$issue', now())";

$result = mysql_query($query) or die("Error in query: $query. " . mysql_error());
//echo result
echo "<font size=-1>Update Successful.<a href=list.php>Go back to the main menu</a>.</font>";
//close db
mysql_close($connection);
}
else
{
//if there are errors, print a list
echo "<font size=-1>The following errors were encountered:<br>";
echo "<ul>";
for ($x=0; $x<sizeof($errorlist); $x++)
    {
    echo "<li>$errorlist[$x]";
    }
echo "</ul></font>";
}

}

?>
</body>

Thanks in advance for all of your help!

Anon

I don't understand your validation. Are you missing some ! signs?

if ($name) ...

techek

Hi Fowler!

Could you specify what kind of problem you have with the script. As tomhath points out you should use "if (!$name) {" if you want to add to the error-array if the name is NOT entered.

Besides you can also forget the $count and just add entries to the errorlist like this :

$errorlist[] = "Invalid entry: Name";

.. and then traverse the array errorlist with this loop :

while(list($index, $value) = each($errorlist)) {
echo "<li>".$value."\n";
}

fowlerlfc

Yes, I also found some other errors and turned set display_errors = on in my php.ini.

My script now gets the following error:

Warning: Undefined variable: submit in D:\Inetpub\wwwroot\user\add.php on line 9

$submit is the variable for my submit button which is in the form. Here's my corrected script:

<head>
<title>Workorder submission form</title>
</head>
<body>
<?
//haven't submitted form, so display it
if (!$submit)
{
?>
<table cellspacing="5" cellpadding="5">
<form action="<?echo $PHP_SELF; ?>" method="post">
<tr>
<td>Name:</td>
<td><input size="50" maxlength="250" type="text" name="name"></td>
</tr>
<tr>
<td>Extension:</td>
<td><input size="4" maxlength="4" type="text" name="ext"></td>
</tr>
<tr>
<td>Email:</td>
<td><input size="50" maxlength="250" type="text" name="email"></td>
</tr>
<tr>
<td>Issue/Error/Problem:</td>
</tr>
<tr>
<td><textarea name="issue" cols="40" rows="20"></textarea></td>
</tr>
<tr>
<td><input type="Submit" name="submit" value="Add"></td>
</tr>
</form>
</table>
<?
}
else
{
//includes files
include("../conf.php");
include("../functions.php");

//setup up an error list array
$errorList = array();
$count = 0;

//validate name field
if (!$name) { $errorList[$count] = "Invalid entry: Name"; $count++; }

//validate ext field
if (!$ext) { $errorList[$count] = "Invalid entry: Extension"; $count++; }

//validate email field
if (!$email) { $errorList[$count] = "Invalid entry: Email"; $count++; }

//validate issue field
if (!$issue) { $errorList[$count] = "Invalid entry: Issue/Error/Problem"; $count++; }

//check for errors in errorlist.
if (sizeof($errorList)==0)
{
//if no errors found
//open db connection
$connection = mysql_connect($host, $user, $pass) or die("Unable to Connect!");
//select db
mysql_select_db($db) or die("Unable to select database!");
//generate and run query
$query = "INSERT INTO wo(name, ext, email, issue, timestamp) VALUES ('$name', '$ext', '$email', '$issue', now())";

$result = mysql_query($query) or die("Error in query: $query. " . mysql_error());
//echo result
echo "<font size=-1>Update Successful.<a href=list.php>Go back to the main menu</a>.</font>";
//close db
mysql_close($connection);
}
else
{
//if there are errors, print a list
echo "<font size=-1>The following errors were encountered:<br>";
echo "<ul>";
for ($x=0; $x<sizeof($errorList); $x++)
    {
    echo "<li>$errorList[$x]";
    }
echo "</ul></font>";
}

}

?>
</body>

Thanks in advance for your help.

fowlerlfc

Thanks for your feedback, I made some changes to my original script and responded to tomhath's post. I am still getting an error. Here it is:

Warning: Undefined variable: submit in D:\Inetpub\wwwroot\user\add.php on line 9

$submit is the variable for my submit button.

Here's my script after changes:

<head>
<title>Workorder submission form</title>
</head>
<body>
<?
//haven't submitted form, so display it
if (!$submit)
{
?>
<table cellspacing="5" cellpadding="5">
<form action="<?echo $PHP_SELF; ?>" method="post">
<tr>
<td>Name:</td>
<td><input size="50" maxlength="250" type="text" name="name"></td>
</tr>
<tr>
<td>Extension:</td>
<td><input size="4" maxlength="4" type="text" name="ext"></td>
</tr>
<tr>
<td>Email:</td>
<td><input size="50" maxlength="250" type="text" name="email"></td>
</tr>
<tr>
<td>Issue/Error/Problem:</td>
</tr>
<tr>
<td><textarea name="issue" cols="40" rows="20"></textarea></td>
</tr>
<tr>
<td><input type="Submit" name="submit" value="Add"></td>
</tr>
</form>
</table>
<?
}
else
{
//includes files
include("../conf.php");
include("../functions.php");

//setup up an error list array
$errorList = array();
$count = 0;

//validate name field
if (!$name) { $errorList[$count] = "Invalid entry: Name"; $count++; }

//validate ext field
if (!$ext) { $errorList[$count] = "Invalid entry: Extension"; $count++; }

//validate email field
if (!$email) { $errorList[$count] = "Invalid entry: Email"; $count++; }

//validate issue field
if (!$issue) { $errorList[$count] = "Invalid entry: Issue/Error/Problem"; $count++; }

$result = mysql_query($query) or die("Error in query: $query. " . mysql_error());
//echo result
echo "<font size=-1>Update Successful.<a href=list.php>Go back to the main menu</a>.</font>";
//close db
mysql_close($connection);
}
else
{
//if there are errors, print a list
echo "<font size=-1>The following errors were encountered:<br>";
echo "<ul>";
for ($x=0; $x<sizeof($errorList); $x++)
    {
    echo "<li>$errorList[$x]";
    }
echo "</ul></font>";
}

}

?>
</body>

Thanks in advance for all of your help!

Anon

Just for the heck of it change

if (!$submit)

if (!$email)

and see what happens. If you get the error or not. Will tell a lot if you do or not

jimbo

Is register_globals turned on or off in your PHP configuration? If it is off, try using

if (!$HTTP_POST_VARS[submit]) {
in place of
if (!$submit) {

If it is on, you can still use the HTTP_POST_VARS array, or you can try
if (!isset($submit)) {

Also,
To view a recursive list of all variables sent to the current page via POST, try using the print_r function like so

print_r($HTTP_POST_VARS);

View the source of your webpage to see the output created by this function.
-Jim