Dropdown list problem

Anon

I create a nice drop down list which is populated from my database.

I then select the item (field) I require and click Test.

This seems to miss out the first entry in the database.

So if I only have 1 item under that field it displays nothing.

If I have 8 items under that field it only displays 7.

What am I doing wrong 🙁 ??

Code for dropdown :

$sql = "SELECT distinct Make from stock";

$rsSelect = mysql_query($sql);
print "<FORM ACTION=\"result.php\">";
echo("<select name='Make'>");
echo("<option selected value=''>Make </option>");

while($row = mysql_fetch_array($rsSelect))
{
echo("<option value='".$row["Make"]."'>".$row["Make"]."</option>");
}
print "</select>";
print "<INPUT TYPE=\"SUBMIT\" VALUE=\"Test\">";
print "</FORM>";
mysql_close($db);

results.php//

// including the navbar class
include("./navbar.php");
// initiate it!
$nav = new navbar;
// set how many records to show at a time
$nav->numrowsperpage = 8;
$sql = "SELECT * FROM stock
WHERE Make = '$Make' ORDER BY Price DESC";
// the third parameter of execute() is optional
$result = $nav->execute($sql, $db, "mysql");
// handle the returned result set
$rows = mysql_num_rows($result);
for ($y = 0; $y < $rows; $y++) {
$data = mysql_fetch_object($result);
echo $data->url . "<br>\n";

if($myrow = mysql_fetch_array($result))
{
echo "<table border=1 align=center bgcolor=#330099 font color=##FFFFFF bordercolor=#000000>\n";
echo "<tr><td><bgcolor=#000000> <div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>VRM</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Make</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Model</i></td><td>
<div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Body</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Doors</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Gearbox</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Miles</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Colour</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1>
<i>Year</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>Price</i></td><td><div align=center><font color=#FFFFFF font face=Arial Black size=+1><i>More Info</i></td></tr>\n";
do {
printf("<tr><td><div align=center><bgcolor=#ffffff><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td>
<div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff>%s</td><td><div align=center><font color=#ffffff><a href=javascript:popUp('search2.php?ID=$myrow[ID]','Details','Height=300,Width=341')>Details</a></td></tr>\n", $myrow[VRM], $myrow[Make], $myrow[Model],$myrow[Body], $myrow[Doors], $myrow[Gearbox], $myrow[Miles], $myrow[Colour], $myrow[Year], $myrow[Price], $myrow[Photo]);
}

while ($myrow = mysql_fetch_array($result));
for($x=0; $x <count($myrow); $x++) {
echo $myrow[$x];
}

echo "</table>\n";
}
else {
}
}
echo "<hr>\n";
// build the returned array of navigation links
$links = $nav->getlinks("all", "on");
for ($y = 0; $y < count($links); $y++) {
echo $links[$y] . "  ";
}

Thanks

Nick Smith

crusty_php

People on this board like to help others, so if you want help try and make your post readable.

Try the following to populate your select:

//get items into option block
while($row = mysql_fetch_array($rsSelect))
{
$option_block .= "<option value = \"$row[Make]\">$row[Make]</option>";
}

//to use in your HTML form

Anon

Sorry not sure what happened with the code going big fonts at the end ??

It must be something to do with my results.php file as your coding does exactly the same.

It parses the variable to the results page, ie: results.php?Make=MERCEDES (or whatever) but when listing all the Mercedes in the database it misses out 1 all the time.

i.e. if I sort by price in descending order it misses out the most expensive ??, but lists all the others properly.

Very strange !

Any ideas thanks for your help Martin

crusty_php

I can't read the code (crappy eyes), but if your using an increment like $S++ try changing it to ++$S

myshoala

When you use the for loop to increment through the records try using the object decleration for a qualifyer :

I.E.
for ($y=0; $object_row = @mysql_fetch_object($sql_result,MYSQL_ASSOC);$y++){
// use info
}

This could also be a while loop byt i like the incremental counter for debugging.