Help Debugging a php/sql script

Anon

🙂 hi i have been stuck on this for hours, can someone give me a hand? 😃 anyways here she is:

newuser.html
///////////////////
<form method="POST" action="newuser.php">
<div align="left"><p><font face="BankGothic Md BT">Name</font>
<input type="text" name="name" size="14">
<br>
<div align="left"><p><font face="BankGothic Md BT">E-Mail</font>
<input type="text" name="email" size="14">
<br>
<div align="left"><p><font face="BankGothic Md BT">Phone #</font>
<input type="text" name="phonenum" size="14">
<br><input type="submit" value="Submit"></p>
</div></form>

newuser.php
////////////////////

<?
$db = mysql_connect("localhost", "root");
mysql_select_db("mydb",$db);
echo "Name: '$POST['name']' Email: '$POST['email']' Phonenumber: '$POST['phonenum']'";
mysql_query("INSERT INTO test VALUES ('$POST['name']', '$POST['email']', $POST['phonenum']', NULL);",$db);
echo "done";
mysql_close();
?>

the error
////////////////////

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /var/www/html/newuser.php on line 5

sarahk

ok. at some stage you need to visit a site like richinstyle.com and get pointers on how to layout your page, but that's another story.
I'd start with rewriting your code as:
$sqlstring = "INSERT INTO test VALUES ('$POST['name']', '$POST['email']', $_POST['phonenum']', NULL);";
echo $sqlstring;
//mysql_query($sqlstring,$db);

then copy the echo'd text into mysql and see if it runs. I suspect you also need to put addslashes() around the name to allow users to enter what they need.

I don't use the $_POST method and have found that $name works fine if a form is posted. I have found that some object calls don't work well inside strings and you need to:
$sqlstring = "insert into test values ('" . $name . "')"; and so on...

Anon

$_POST["name"] not a method of an object, its an element of a global array. However, the last line of Sarah's post is correct.

There are too many quotes in the strings, get the php variables out of the quoted text and concatenate evetything back together (you can use $_POST["name"] or $name, same thing).

echo "Name: " . $POST["name"] . " Email: " . $POST["email"] . " Phonenumber: " . $_POST["phonenum"];