DB help!!!

[Anon]

Hey,

I've made a simple database script and I need something that'll make my site easier to use. I'm not a complete wiz like alot of the people here, but I'm just trying to make things nicer.

My problem is when I call the test script from a browser dbtest.php?id=1 or id=2 it'll pull up all the records in the database. How do I fix this?

Also, if anyone has any suggestions for good template systems or anything, I would appreciate it. I tried using Smarty, but it's not working since for some reason there's no PEAR.php on my system.

HELP!!! Thanks...

JD

[ruttiger]

i'd have to see your SQL to know why it pulls up all your records

[Anon]

Well... here's the snippet just after all the connection info...

$db = @mysql_select_db($db_name, $connection) or die("Couldn't select database.");
$sql = "SELECT id, nid, notes, html FROM $table_name ORDER BY id";
$result = @($sql, $connection) or die("Couldn't execute query.");
while ($row = mysql_fetch_array($result)) {
$id = $row['id'];
$nid = $row['nid'];
$notes = $row['notes'];
$html = $row['html'];
$display_block .= "
<p><strong>$nid</strong><br>
$notes<br>
$html</p>";<<

[ruttiger]

you're not using your GET data (?id=1, ?id=2). you're telling MySQL that you want all the rows.

modify your SQL statement like this:

$sql = "SELECT id, nid, notes, html FROM $table_name WHERE id=".$HTTP_GET_VARS['id'];

you could use $id instead of $HTTP_GET_VARS['id'], but i see you're using $id somewhere else, so to be safe, I always use the GET & POST arrays.

this SQL statement will only grab that one ID that you have as GET data.

i assume column "id" is an integer, not a string - cause you'd need quotes around it if it were a string.

hope this is what you were lookin for

blake_caldwell
Pluginbox.com

[Anon]

That seemed to work, thank you very much!