isset() and/or ( !$sql_result)

Anon

Hello,

I've tried this every way I can think of using all different variables in different places and different ways all over the script. I can't even find a workaround.

I need to display a message if the query comes back empty. I have worked a lot with...

if (!$sql_result) echo ("Message");

and

if (!isset($sql_result)) {
echo "this";
} else {
echo "that";
}

Changing the variables and exclamation mark etc. The message stays the same no matter if the query is empty or not.

Thank you.

Richard

glansing

$query = "SELECT * FROM whatever WHERE whatever=whatever";
$result=mysql_query($query);
if (!$result) {
echo "Query Failed.";
}
else {
//yay!, now do something
}

that's always worked for me...
-g

Anon

U can just simply get the number of records ur result returns using mysql_num_rows().

refer to http://www.php.net/manual/en/function.msql-num-rows.php

Anon

Thanks Gerrit

For some reason it's still not working. Here is exactly what I have...

$sql = "select zone, date_last_visited, zone_desc, current_status, sector from assign where current_status = 'off' and sector = 'w_or' ORDER BY date_last_visited ASC";

$sql_result = mysql_query($sql)
or die(mysql_error());

if (!$sql_result) {
echo "Query Failed.";
}
else {
echo "ok";
}

It just shows "ok" whether results are returned or not

Anon

Thanks Jem

Does this look reasonable? It does work...

$test = Mysql_num_rows($sql_result);

if ($test < 1 ) {
echo "Query Failed.";
}
else {
echo "ok";
}

Thanks!

Richard

glansing

hmm, try removing the or die() call... i rarely use die(), especially with a following if statement, it could be conflicting, never know... the if (!$sql_result) has always worked for me... -gerrit

Anon

Nope. Still won't work. Thought it might have something to do with using it on my home machine so uploaded it to a server. Still the same.

[deleted]

Error checking is everything. Try soemthing like this:
(and stop using the OR DIE function, it creates more problems than it solves)

if (mysql_connect($host,$user,$password))
{
if (mysql_select_db($database))
{
if ($result = mysql_query($sql))
{
if (mysql_num_rows($result)>0)
{
// Yay, results found
}
else
{
// No results found
};
}
else
{
// Query failed
echo mysql_error()."<BR>\n".$sql;
};
}
else
{
echo 'Could not select database';
};
}
else
{
echo 'Could not connect to database server';
};

Anon

Will do...

Very helpful thank you!

Richard

jamie_webstart

I always use:

if (!mysql_num_rows($result))
{
// empty result
}
else
{
// 1 or more rows
}

There was a bit of confusion in the other thread, the code 'if (!mysql_query($query))' is for checking the query was valid and executed... even if it returns no values, it was still valid and executed so you would expect to get a true returned.

HTH