What is wrong with this query script?

four_d

What is wrong with this? All I want is the three fields info to be displayed in table format, but all it does is display the nick_names in all three coloumns in a continuos loop.

$sqlmembers = mysql_query ("SELECT nick_name,email, url FROM members ORDER by id asc");

while(mysql_fetch_row($sqlmembers)){
$nick_name=mysql_result($sqlmembers);
$email=mysql_result($sqlmembers);
$url=mysql_result($sqlmembers);
echo "<table border='1'cellpadding='1' cellspacing='1' width='100%'>";
echo "<tr>";
echo "<td width='50%'>$nick_name</td><td width='25%'>$email</td><td width='25%'>$url</td>";
echo "</tr>";

}

Donald

jburfield

I do this:
<?
// stuff above....

$sqlmembers = mysql_query ("SELECT nick_name,email, url FROM members ORDER by id asc");

print("<table border=\"1\" cellpadding=\"1\" cellspacing=\"1\" width=\"100%\">\n");

while($row = @mysql_fetch_row($sqlmembers))
{
$nick_name = $row[0];
$email = $row[1];
$url = $row[2];

 print("<tr>\n"); 
 print("<td width=\"50%\">$nick_name</td><td width=\"25%\">$email</td><td width=\"25%\">$url</td>"; 
 print("</tr>\n");
 }

print("</table>\n");

// etc code down here...
?>

That will start the table, then create a new <tr> for each result row.

This should at least point you in a good in a direction...

-- Jason

Four_D wrote:

What is wrong with this? All I want is the three fields info to be displayed in table format, but all it does is display the nick_names in all three coloumns in a continuos loop.

$sqlmembers = mysql_query ("SELECT nick_name,email, url FROM members ORDER by id asc");

}

Donald

Anon

try this

while($row = mysql_fetch_array($sqlmembers)){
$nick_name=$row[nick_name];
$email=$row[email];
$url=$row[url];

echo "<tableborder='1'cellpadding='1' cellspacing='1' width='100%'>";
echo "<tr>";
echo "<td width='50%'>$nick_name</td><td width='25%'>$email</td><td width='25%'>$url</td>";
echo "</tr>";
}
good day
gd

Anon

Change this code:

while(mysql_fetch_row($sqlmembers)){
$nick_name=mysql_result($sqlmembers);
$email=mysql_result($sqlmembers);
$url=mysql_result($sqlmembers);

To this:

while($row = mysql_fetch_row($sqlmembers)){
$nick_name=$row[0];
$email=$row[1];
$url=$row[2];

I suggest your read over what the functions that you are trying to use do:
http://www.php.net/manual/en/ref.mysql.php

It will help out alot. mysql_result() needs more information to return something. And mysql_fetch_row() returns an array that you need to catch if you want to use it.

four_d

Thanks to all of you. I just started with php and mysql monday.

I find the manual is pretty useful, but sometimes difficult as not all the examples work.

I was obviously trying to use the wrong function. I was converting from asdp/odbc query to php/mysql and was getting confused...

Thanks everyone.

Donald

Anon

In other words, why do unnecessary work? You see this kind of thing all the time:

while($row = @mysql_fetch_row($sqlmembers))
  {
  $nick_name = $row[0];
  $email = $row[1];
  $url = $row[2];

but if you want the data in $nick_name, $email, and $url why not just put it there in the first place?

while( list($nick_name,$email,$url) =
  =@mysql_fetch_row($sqlmembers))
  {

techjosh

while( $row =@mysql_fetch_row($sqlmembers))

What does the @ do?

some people put it and others dont. Is it some kind of index incrememtor?

Anon

The @ in an expression suppresses php's automatic error message. I would have taken it out if I noticed it--there are some contexts where it's ok, but never in database functions, unless you are substituting some other method of reporting the error.

That is, this is asking for trouble:

$result = @($sql);

Whereas this is just fine:

if ( $result = @($sql))
  {
  // do something with the results
  }
else
  mail( $site_admin,'sql problem',
    mysql_error() );