need help

Anon

Hello all...

I have some problems with the following code.

function insertactor ( $val2, $val3 ) {

$actor_name = "actor_name";
$actor_sur  = "actor_sur";
$sqlinsertactor = "INSERT INTO actor ($actor_name, $actor_sur) VALUES ( $val2, $val3 )";

echo $sqlinsertactor;	

if ( ($val2 == "") || ($val3 == "" ) ) {
	echo "Where is val2 or val3?";
	exit;
}
$new = @mysql_db_query($dbname1, $sqlinsertactor);
if (!$new) {
echo ("<br><br><center>Query cannot be executed.</center>");
exit();
}

}

insertactor( "Hello", "World" );

I dont know what the problem is... I execute the query from outside the function and it work... but once i execute insertactor function... all i get is Query cannot be executed...

Could someone please help me?

Thank you
George

smarlowe

You've run afoul of PHP's vicious anti-global variable design. It's actually a good thing that will teach you to program well, but a pain for beginners.

Basically, in PHP, global variables don't exist within functions by default. Since $dbname1 is not assigned in the function, the function can't see it. To "suck it in" to the function (not recommended) use the global keyword like so:

function myfunc ($var1, $var2){
global $dbname;

(rest of function goes here)
}

Or you can pass it in as an argument:

function myfunc($var1, $var2, $dbname){

which is how I recommend doing it.

Anon

Hello Scott

I have already tried this function myfunc($var1, $var2, $dbname){ But it seems that there is another problem because i am getting the same problem...

🙁

I ll try again and i hope that i ll manage to solve the problem...

George

ace21

$sqlinsertactor = "INSERT INTO actor ($actor_name, $actor_sur) VALUES ( '$val2', '$val3' )";

try this

Ace21

Anon

Hey Ace

Thank you for your help...

It worked this time... Could u please explain me what is the difference between <b>$sqlinsertactor = "INSERT INTO actor ($actor_name, $actor_sur) VALUES ( $val2, $val3 )";</b>

and this

<b>$sqlinsertactor = "INSERT INTO actor ($actor_name, $actor_sur) VALUES ( '$val2', '$val3' )";</b>

Thank you guys

ace21

$actor_name, $actor_sur are text fields in mysql thus the need for the single quotes around the variables being inserted.

Ace21

Anon

in other owrds you use single quotes around text such as:

name='jason'

but you don't use single quotes around numbers, like

name_id=47

make sense?