Parse Error? But is seems ok to me...

[Anon]

Ok here's the code that gives me the parse error:

<?php

$dbhost = "localhost";
$dbuser = "root";
$dbpass = "pass";
$dbname = "name";

$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db($dbname);
$result = mysql_query("SELECT * FROM blocks DESC LIMIT 15", $db);
while (list($id, $title, $url, $description) = mysql_fetch_row($result)) {
if (!$HTTP_POST_VARS['submit']){
echo "<a href=\"$url\" title=\"$description\">$title</a><br>";
}
} else {
$result = mysql_query("INSERT INTO blocks (id,title,url,description) VALUES (NULL,'$title','$url','$description')");
echo "<script>\n"
."function redirect()\n"
."{\n"
."window.location.replace(\"index.php\");\n"
."}\n"
."setTimeout(\"redirect();\", 6000);\n"
."</script>\n"
."<center>Link added to the database. Please wait while I redirect you...<br>Else you can <a href=\"index.php\">click here</a>.</center>\n";
}

?>

The erro is at line 15 where the else statement is... What did I do wrong? If it is obvious please don't call me idiot. It's 4:00 am and I'm still coding... 🙁

[Anon]

I believe the problem is because you have the else statement on your while loop (which you can not have). I think you meant to have it like this:

while (list($id, $title, $url, $description) = mysql_fetch_row($result)) {
if (!$HTTP_POST_VARS['submit']){
echo "<a href=\"$url\" title=\"$description\">$title</a><br>";
} else {
$result = mysql_query("INSERT INTO blocks (id,title,url,description) VALUES (NULL,'$title','$url','$description')");
echo "<script>\n"
."function redirect()\n"
."{\n"
."window.location.replace(\"index.php\");\n"
."}\n"
."setTimeout(\"redirect();\", 6000);\n"
."</script>\n"
."<center>Link added to the database. Please wait while I redirect you...<br>Else you can <a href=\"index.php\">click here</a>.</center>\n";
}
}

Hope this helps a bit,
-Josh B

[[deleted]]

This just proves once more that the syntax of putting the { tags after the while and IF is extremely bad.

Always put the opening brackets { on a new line, that way you can match up the opening and closing brackets and you would have seen rightaway that you have one closing bracket too many after your IF:

Your code:
while (list($id, $title, $url, $description) = mysql_fetch_row($result)) {
if (!$HTTP_POST_VARS['submit']){
echo "<a href=\"$url\" title=\"$description\">$title</a><br>";
}
} else {
$result = mysql_query("INSERT INTO blocks (id,title,url,description) VALUES (NULL,'$title','$url','$description')");
echo "<script>\n"

The same in proper syntax:
while (list($id, $title, $url, $description) = mysql_fetch_row($result))
{
if (!$HTTP_POST_VARS['submit'])
{
echo "<a href=\"$url\" title=\"$description\">$title</a><br>";
}
}
else
{
$result = mysql_query("INSERT INTO blocks (id,title,url,description) VALUES (NULL,'$title','$url','$description')");
echo "<script>\n"

see the difference? 🙂
Also indenting is a must (but you knew that already didn't you?)

[gerardg]

How about when you got a misplaced ( hidden in all those {'s? Is there a way in editplus to differentiate them with colors?

[[deleted]]

Nope, but you can do the same indenting trick to find matching parentheses:

if (((1==2) OR (4==3)) AND (5==6))

or
if&nbsp;(
&nbsp;&nbsp;&nbsp;&nbsp;(
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;(1==2)&nbsp;OR&nbsp;(4==3)
&nbsp;&nbsp;&nbsp;&nbsp😉
&nbsp;&nbsp;&nbsp;&nbsp;AND&nbsp;
&nbsp;&nbsp;&nbsp;&nbsp;(5==6)
&nbsp;&nbsp;&nbsp😉