dynamic nav using a db....need help!

[eclipze]

ok. I have a table in my database named pages. I am using one script to view all my pages by selecting the row from the table that corresponds to the variable set in the URL. An example would be index.php?view=news would search the database for a news row and then return the contents as the variable &text. I have a value in each row to specify if the content is code or html. Next I have 2 if statements that check if its code or html, and then depending on what the result is, it displays the text in either an echo, or an eval. Is this the most efficient way to do this, or is there a better more precise way?

here is my code

$dbhost = "localhost" ;
$dbuser = "xxxxx" ;
$dbpass = "xxxxx" ;
$db = "mydb" ;
$default = "news" ;

if (empty($view)) $view = $default;

$connect = mysql_connect($dbhost, $dbuser, $dbpass) ;
mysql_select_db($db,$sql) ;

navigation($action,"") ;

mysql_close($sql) ;

function navigation($view,$name)
{
global $sql
$sql = mysql_query("SELECT * FROM pages where and name='$page'",$connect) ;
$check = mysql_fetch_array($sql);
$text = stripslashes($check

); 
	$type = strtolower($check[type]); 
	if ($type == "html")	echo $text; 
	if ($type == "code")	eval($text); 
}

also, when i do eval on a login page i have that works when parsed regular when loading login.php, it creates an eval error when i insert it into the database.  

[Anon]

I do something similar on my site, and I have also done it this way. The only other way I can think of is to create a temp file, dump the contents in there, and then include it using include() or require(). THis way you wouldnt have to worry about using echo or eval, as it would work that out from the <? ?> tags in your file.

Are you getting the eval error because of quotes or something?

[eclipze]

i did a test, and it cant handle printf(). I have no idea why, but it just doesnt want to parse it. And when i try to echo stuff that needs to be in the printf() function, it just gives me a warning about not being able to subtract from zero which is quite odd. Can anyone else Verify why printf() wont work when evaluating?