Mssql and Update

Anon

Can anyone tell me if there is work around for Updating a table with php and Mssql?

Here's my code:

db_name = "directory";

$table_name = "phone";

$connection = @mssql_connect("local", "user", "password") or die("Couldn't connect.");

$db = @mssql_select_db($db_name, $connection) or die("Couldn't select database.");

$sql = "Update [$table_name]

SET
Name = \"$Name\",
Ext# = \"$Ext\",
Cell # = \"$Cell\",
Dept# = \"$Dept\",
WHERE Name = \"$Name\"
";

$result = @mssql_query($sql,$connection) or die("Couldn't execute query.");

Any help is greatly appreciated. Thanks.

tomhath

The SQL statement you posted has several problems. What are those "#" signs all over the place? There's an extra comma before the WHERE. You never check the error message. And what are you really asking? An update is an update, what kind of workaround are you looking for?

I suggest two things:

1) Use myphpadmin to get a syntactically correct statement before trying to run it through php

2) use mysql_error to get an idea of what's wrong when running from php

Anon

Excuse me for being new at this. I'm sure you started somewhere, tomhath.

The #'s your referring to were translated in my mssql database from an excel spreadsheet.

Anyway,
Update does not seem to work in Mssql. (Atleast not for me.)
Can anyone (sensitive to newbies) give me a little help?

Thanks.

Anon

First,

I noticed your column names had spaces in them. You should either remove those, or replace them with an _. Also, you should replace the "#" symbols with "num". Having only letters and numbers in a column and table name makes things a little less messy.

Try putting your Query string all on one line, and using the string joiner (.) to join all the strings.

I've found it beneficial to give your variables meaningful names. If it's a string put "str" or "string" in the variable name, for example, and what that string is for. More typing, I know, but it saves headaches.

Finally, if you have a string with a lot of escaped characters (namely quotes), use an ' to define the string. Makes everything look neater, and I believe it helps a bit with performance.

$personUpdateString = 'Update ' . $table_name . ' SET Name = "' . $Name . '", ExtNum = "' . $Ext . '", CellNum = "' . $Cell . '", DeptNum = "' . $Dept . '" WHERE Name = "' . $name . '";

Hope that helps.