Problem writing to database...

rupertbj

Problem writing to database...
I am trying to use the following script to add users to a database of e-mail addresses to be used for a mailing list. I don't understand why it doesn't work. I have created a database called register and a table called email using phpMyAdmin.
Thanks in advance for your help!

<?php
if ((!ereg(".+@.+..+", $user)) || (!ereg("^{[a-zA-Z0-9_@.-]+$",} $user)))
{
print "
<body bgcolor=\"#8080FF\">
<b>Invalid Email address! Please <a href=/index.html>register</a> properly!!!</b>
";
exit;
}
else
{
setcookie( "user", $user, "0" );
$db = "register";
$link = mysql_connect( "localhost", "root" );
if ( !$link ) die( "Couldn't connect to MySQL" );
mysql_select_db( $db, $link ) or die( "Couldn't open $db: ".mysql_error() );
$sql = "INSERT INTO email VALUES ('', '$user' )";
if ( mysql_query( $sql, $link ) )
{
echo "record added!";
}
else
{
echo "error - something went wrong!";
}
mysql_close( $link );
}
?>

siwis

Possibly try:

if ( mysql_query( "$sql", $link ) )

Also, as you haven't included your table structure for "email", I will have to assume that you are entering exactly the correct number of column entries in your sql.

Again, another possibility: Where's your db password as there is no sign of it in your above script. Even if connecting as root, a password IS required.
$db = mysql_connect($dbhost , $dbusername , $dbpw);
mysql_select_db("$dbname",$db);

Slightly off-topic, but you might want to consider adding a simple check to prevent duplicate addresses being added to your db aswell.