INSERT into mysql

Anon

Can someone tell me what is wrong with this code?

I can SELECT just fine. Running php4 and mysql on win 98

<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<?php

if ($submit) {

echo "Thanks for updating\n";

$db = mysql_connect("localhost", "root");
mysql_select_db("ptax",$db);

$sql = "INSERT INTO test_table (Name,last)VALUES ('$Name','$last')";

$result = mysql_query($sql);

} else{

<form method="post" action="<?php echo $PHP_SELF?>">
First Name <input type="text" name="Name"><br>
Last Name <input type="text" name="last"><br>

<?php
}

?>
</body>

Anon

Two possible things are going wrong here:

$sql = "INSERT INTO test_table (Name,last)VALUES ('$Name','$last')";

It could be that you need another space after "(Name,last)Values" So that it reads:
"(Name,last) Values"

The other thing that could be going wrong is that the vars that you are submitting to the database are not the correct types for those fields (It's a long shot but you might as well check the db field types) or that the vars could someone be being made into arrays.

You could help out the community if you posted the code that submits the vars (a form?) or at least part of it. Thank you.

Anon

I've tried the spacing and it has no affect.
In terms of the var and the submit form (the form is in the original message), everything is text.

Any other ideas....I hope

Anon

What errors are you getting?

You could try putting the $db variable in the mysql_query. For example:
$result = mysql_query($sql,$db);

Gary

Anon

<! Try this....Tested on my machine: Win98, Mysql, Apache 1.3.12, PHP4.0.1pl2

CREATE TABLE test2 (
id int(10) NOT NULL,
name varchar(100)
);

<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<?php

if ($submit) {

echo "Thanks for updating\n";

$db = mysql_connect("localhost", "root");
mysql_select_db("test",$db);

$sql = "INSERT INTO test2 (id,name) VALUES ('$id','$name')";

$result = mysql_query($sql);
} else {
?>

<?php
}
?>
</body>

Anon

tell me your wrong message,and the wrong line,which line is wrong?
try to modify the line--
$db = mysql_connect("localhost", "root");

change to:
$db = mysql_connect("localhost", "root","");

Anon

Often good thing to do:
Change:
$sql = "INSERT INTO test_table (Name,last)VALUES ('$Name','$last')";
$result = mysql_query($sql);

To:
$sql = "INSERT INTO test_table (Name,last)VALUES ('$Name','$last')";
echo $sql;
#$result = mysql_query($sql);

Shows you the resulting SQL statement without doing anything.

Anon

It worked, and I think I see my error.
Is it correct to say that and insert statement must reference all columns?

Once I did that with the original code it worked.

Thanks MUCH!!!