I'm lost... mySQL table creating prob...

Anon

I am having a problem with this script - can anyone see where it is going awry?

<?php

$newTable = mysql_connect("localhost", "", "");
if(! $newTable) {
die("Damn");
} else {
mysql_select_db("monkeytest", $newTable);
$query = "create table mailing_list ( id INT NOT NULL AUTO_INCREMENT,
PRIMARY KEY(id)
registerName VARCHAR(30)
registerEmail VARCHAR(70)
registerLocation VARCHAR(60)
registerDate VARCHAR(10)
)";
mysql_query($query, $newTable
print "Big Jobs...";
}

Anon

It goes as far as printing 'Big Jobs...' but no table is created...

The code I submitted earlier does actually have a

);

after the

mysql_query($query, $newTable);

toma42

create table mailing_list ( id INT NOT NULL AUTO_INCREMENT,
PRIMARY KEY(id)

you can simplify this statement by removing the , and just saying primary key after auto_increment. adding int unsigned is a good idea too.

If you add commas after your columns, I think you'll have better luck but it's a bad idea, usually, to create new tables through code.

Tom

Anon

...Amazing what you miss when you stare at something for that long...!

Not sure what you meant by the PRIMARY KEY but the sql seems to work now. Have yet to see what's being written but hopefully it is what I expect... 🙂

Cheers again.

Tony.

toma42

create table mailing_list ( id INT NOT NULL AUTO_INCREMENT,
PRIMARY KEY(id)

Here, you define two table entities, an id column and a primary key.

You can simplify this by typing id as

id int unsigned not null primary key auto_increment

so you don't need the seperate primary key(id). The primary key (fieldname) is usually used when you have a multi-column primary key like primary key(ref_table1, ref_table2).

Tom

Anon

Okay, I think i'll drop the table I made before and do that then - cheers, great help...

🙂