mysql and forms

Anon

The code below keeps giving me an error message on line 27. I'm new to php but was able to put this mysql input form together I need help im stuck.

<?php
//This portion checks to see if all of the fields have been filled in

if((!$sale_id) || (!$sale_name) || (!$sale_address) || (!$sale_month)
  || (!$sale_date) || (!$sale_stime) || (!$sale_ftime)) {
header("http://www.mysite.com/garageform/garageform1.htm");
exit;
}

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">

<HEAD>
<TITLE>Garage Sale Submission</TITLE>
</HEAD>
<BODY>
<h1>FCE thanks you for adding your Garage Sale<h1>
<?php
//This declares the sql command as a varible

$sql= "INSERT INTO GARAGE_SALES (SALE_ID, SALE_NAME, SALE_ADDRESS, SALE_MONTH
SALE_DATE, SALE_STIME, SALE_FTIME)
VALUES ('$sale_id','$sale_name','$sale_address','$sale_month',
'$sale_date','$sale_stime','$sale_ftime');

//connects to database
$connection = mysql_connect("localhost","user","password") or die ("Couldn't connect to server.");

$db = mysql_select_db("dbname",$connection); // or die ("Could'nt select database.");

//execute SQL query and get result
$sql_result = mysql_query($sql,$connection) or die ("Coul'nt execute query.");

if (!$sql_result) {
	echo "<P>Could'nt add record!";
} else {

echo "

Anon

What's missing from this line? Take a long look:

You're missing a double quotation mark. =) Hope that helps..

Here's a tip: Next time you're stuck, go away from the computer for no less than twenty minutes and start fresh.

Anon

I still can't get it I still get an error message up in here somewhere. I added the " just as you said SALE_FTIME") Man I got to admit I'm not that good, plus it's late I'm going to look at it again tomorrow, But if you can help me show me where to insert it at.

Anon

Hi there,

Your line:
$sql= "INSERT INTO GARAGE_SALES (SALE_ID, SALE_NAME, SALE_ADDRESS, SALE_MONTH
SALE_DATE, SALE_STIME, SALE_FTIME)
VALUES ('$sale_id','$sale_name','$sale_address','$sale_month',
'$sale_date','$sale_stime','$sale_ftime');

try this:
$sql= "INSERT INTO GARAGE_SALES (SALE_ID, SALE_NAME, SALE_ADDRESS, SALE_MONTH
SALE_DATE, SALE_STIME, SALE_FTIME)
VALUES ($sale_id,'$sale_name','$sale_address','$sale_month',
'$sale_date','$sale_stime','$sale_ftime')";

" at the end of the line and i'll guess your sale_id is an integer, so put away your ' for that field. and forhaps you'll have a field in your table which must be filled...??
make a default value in your form if so.
good luck

Anon

Sorry I wasn't more explicit about where the doublequote should appear.. I was in a mood. 😉 Kio: the sql statement should probably work anyway with the single quotes around the int. Right?

Should probably work even if you leave it alone and simply add the double quote where it belongs:
New line:
$sql= "INSERT INTO GARAGE_SALES (SALE_ID, SALE_NAME, SALE_ADDRESS, SALE_MONTH
SALE_DATE, SALE_STIME, SALE_FTIME)
VALUES ('$sale_id','$sale_name','$sale_address','$sale_month',
'$sale_date','$sale_stime','$sale_ftime')";

kio wrote:

Hi there,

Anon

Parse error: parse error on line 27
is now the error message I get after making the changes Kio told me to make. This is starting to become very interesting for me. I also tried it the other way that Spencer told me to. Still I get a Parse error message. Does this mean I may need to look at my Db?

Anon

Paste the code again...

cmack wrote:

Anon

Here is the entire code. Hey man I really appreciate this. I'm at a dead end. I have never been to this site before I just read books, but I'm really at a dead end.

<?php
//This portion checks to see if all of the fields have been filled in

if((!$sale_id) || (!$sale_name) || (!$sale_address) || (!$sale_month)
  || (!$sale_date) || (!$sale_stime) || (!$sale_ftime)) {
header("http://www.mysite.com/garageform/garageform2.htm");
exit;
}

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">

<HEAD>
<TITLE>Garage Sale Submission</TITLE>
</HEAD>
<BODY>
<h1>FCE thanks you for adding your Garage Sale<h1>
<?php
//This declares the sql command as a varible

$sql= "INSERT INTO GARAGE_SALES (SALE_ID, SALE_NAME, SALE_ADDRESS, SALE_MONTH
SALE_DATE, SALE_STIME, SALE_FTIME)
VALUES ($sale_id, '$sale_name','$sale_address','$sale_month',
'$sale_date','$sale_stime','$sale_ftime')";

//connects to database
$conn = mysql_connect("localhost", "username", "mypassword");or die ("Couldn't connect to server.");

$db = mysql_select_db("my_db",$conn);or die ("Couldn't connect to server.");

//execute SQL query and get result
$sql_result = mysql_query($sql,$connection) or die ("Coul'nt execute query.");

if (!$sql_result) {
    echo "<P>Could'nt add record!";
} else {

echo "
<P>Garage Sale Added</P>
<table cellspacing=5 cellpadding=5>
<tr>
<td> valign=top><strong>Garage Sale Id#:</strong></td>
<td> valign=top>$sale_id</td>
</tr>
<tr>
<td> valign=top><strong>Garage Sale Name:</strong></td>
<td> valign=top>$sale_name</td>
</tr>
<tr>
<td> valign=top><strong>Garage Sale Address:</strong></td>
<td> valign=top>$sale_address</td>
</tr>
<tr>
<td> valign=top><strong>Garage Sale Month:</strong></td>
<td> valign=top>$sale_month</td>
</tr>
<tr>
<td> valign=top><strong>Garage Sale Date:</strong></td>
<td> valign=top>$sale_date</td>
</tr>
<tr>
<td> valign=top><strong>Garage Sale Start Time:</strong></td>
<td> valign=top>$sale_stime</td>
</tr>
<tr>
<td> valign=top><strong>Garage Sale Finish Time:</strong></td>
<td> valign=top>$sale_ftime</td>
</tr>
</TABLE>
";
}

?>
</BODY>

Anon

Hi,

i made a quick look at your source and i missed a , between sale_month and sale_date see also your line:

usually i'll make this kind of syntax:

$query="select blablabla";
if the syntax doesn't work i'll print the query;
print $query; ##a tip to see what's mysql is doing
$result=mysql_query("$query");
$row=mysql_fetch_array($result);
tomorrow i'll take your code to work and will simulate it.
good luck so far..
greetz...kio

Anon

Well..first of all....I think that this:

header("http://www.mysite.com/garageform/garageform2.htm");

Should be this:

header("Location: http://www.mysite.com/garageform/garageform2.htm");

Kio is right...you're missing a comma after the column name "SALE_MONTH
" in the sql statement..
Other than that...I don't see anything wrong..

Anon

added comma same error message as before. I will stript the code down tonight and try to rewrite it all over from scratch, Could it be my DB the way I have it set up. I'm not familiar with error messages so the parse error dosn't tell me where to look. Thanks you guys, I'm not giving up it's just I need to go back to the drawing board. I not a quitter, I just don't want to keep wasting you guys time. Kio let me know what kind of results you get after running it. Thanks Spencer.

Anon

Thanks guys I came home from work and rebuilt the entire page and it worked. I think I had also left off a ( at the begining of the if statement for the for check of populated fields in the form. I learned a lot and I hope we don't meet like this again but on better terms. Thanks