'echo' parse arse error with Mysql query

Anon

Hi All,
Can anyone tell me what is wrong with the code below, I've been looking for hours. I have a form with a username and password which goes to this script. It's meant to check them against the database of users but I continually get parse errors on the line where I use echo! (Database is working and the table does exists. The SQL statement works with PhpMyAdmin)
<?php
$connection=mysql_connect("localhost", "username", "password") or die ("Could not connect to MySql");
$db=mysql_select_db("mydatabase", $connection) or die ("Couldn't connect to database!");
$sql = "SELECT id FROM users WHERE username = '$username' and password = '$password'";
$result = mysql_query($sql, $connection) or die ("Couldn't execute query!");
$num = mysql_numrows($result) or die ("Could not authenticate!)
if ($num == 0) {
echo "You are not an authorised user!";
}
else if ($num == 1) {
echo "You are authorised!";
}
?>

Anon

You're missing a " in the die() statement on the $num = mysql_numrows($result) line.

Anon

Thanks heaps .... how couldn't I see it!!!

My only problem now is that if I have the correct username and password it works, but if I don't have the correct username or password I get the "Could not authenticate!" from the die statement. Is there a work around?

$num = mysql_numrows($result) or die ("Could not authenticate!")
if ($num == 0) {
echo "You are not an authorised user!";
}
else if ($num == 1) {
echo "You are authorised!";
}

Any ideas much appreciated as always 🙂
cheers
Darrel

aroderick

I am not sure this would work but you can try it

first remove the die statement and see if you get the error "$result is not a valid mysql result resource" if you do, then change the die message to you are not an authorized user. Because there are no results in the query, $result is not a valid argument for the mysql_num_rows command and will display the die statement.

Hope it works,
Adam